[PATCH] D81251: [AArch64] Add BTI to CFI jumptables.
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 1 04:38:50 PDT 2020
chill added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:1398
+ if (JumpTableArch == Triple::aarch64) {
+ F->addFnAttr("ignore-branch-target-enforcement");
+ F->addFnAttr("ignore-sign-return-address");
----------------
Why are we disabling BTI here?
================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:1399
+ F->addFnAttr("ignore-branch-target-enforcement");
+ F->addFnAttr("ignore-sign-return-address");
+ }
----------------
Here we should use `sign-return-address=none`, and, if needed, I suggest (re-)introducing `branch-target-enforcement=true|false` ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81251/new/
https://reviews.llvm.org/D81251
More information about the llvm-commits
mailing list