[PATCH] D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Other/print-on-crash.ll:5
+
+; RUN: (opt -print-on-crash -passes=trigger-crash || true) < %s 2>&1 | FileCheck %s --check-prefix=CHECK1
+
----------------
I think the typical way is `not --crash opt ...`.
Not sure if this may `REQUIRES: asserts` or not


================
Comment at: llvm/test/Other/print-on-crash.ll:14
+
+; CHECK1: *** Dump of IR Before Last Pass TriggerCrashPass Started ***
+; CHECK2-NOT: *** Dump of IR Before Last Pass TriggerCrashPass Started ***
----------------
maybe check that some or the IR is printed? at least a function name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86657/new/

https://reviews.llvm.org/D86657