[PATCH] D86847: [Bitcode] Add BITCODE_SIZE_BLOCK_ID to encode the size of the bitcode

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 16:22:46 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added a comment.

In D86847#2248353 <https://reviews.llvm.org/D86847#2248353>, @steven_wu wrote:

> I am a bit worry that linker might concatenate bitcode file with padding to achieve alignment requirement, etc. I guess you can create a termination block to mark the end but it is hard to seek the next start.

We can set the section alignment to 1 to avoid padding: (I rushed a bit, sorry: 6ae7b403c3e1aebcb825d3dd4777d3c1149d6d67 <https://reviews.llvm.org/rG6ae7b403c3e1aebcb825d3dd4777d3c1149d6d67>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86847/new/

https://reviews.llvm.org/D86847



More information about the llvm-commits mailing list