[PATCH] D86892: Improve error handling for SmallVector programming errors.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

`std::throw_length_error(char const*)` is indeed more appropriate if we intend to match the standard interface. Since we also need to work in the absence of exceptions, `report_fatal_error` seems good as an alternative.



================
Comment at: llvm/lib/Support/ErrorHandling.cpp:175
+  (void)::write(2, Reason, strlen(Reason));
+  (void)::write(2, newline, strlen(newline));
   abort();
----------------
`(void)::write(2, "\n", 1);`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86892/new/

https://reviews.llvm.org/D86892