[PATCH] D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 15:25:53 PDT 2020


delcypher added a comment.

In D86379#2248114 <https://reviews.llvm.org/D86379#2248114>, @kubamracek wrote:

> Also, I understand that the code in question isn't best already, but I don't have the bandwidth to refactor and test any more extensive changes. I'm only trying to address the problem of getting -arch arm64 / arm64e passed into tests, otherwise we're testing the wrong thing. Let's focus on that, please.

I'm not saying you have to fix it in more an extensive way. I am just making sure that fixing this in a more extensive and better way is at least considered as an option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86379/new/

https://reviews.llvm.org/D86379



More information about the llvm-commits mailing list