[PATCH] D71267: [OpenMPIRBuilder] Add support for generating kmpc_for_static_fini

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

You should not need to update the tests as that will be a lot. We will soonish be able to auto-generate the check lines for the existing tests and updates will be less painful.
For now, there should not even be a need as we might be able to test this via existing tests and check lines, see my comment below.



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2819
+  }
 }
 
----------------
We do emit exactly the same code in both cases, don't we?
If so, use the always available OMPIRBuilder unconditionally.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:92
+bool isOpenMPLoopDirective(Directive DKind);
+
 } // end namespace omp
----------------
Where is the definition for these?


================
Comment at: llvm/lib/Frontend/OpenMP/CMakeLists.txt:7
   OMP.cpp # Generated by tablegen above
+  OMPConstants.cpp
   OMPContext.cpp
----------------
Do we still have that file?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71267/new/

https://reviews.llvm.org/D71267