[PATCH] D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: compiler-rt/cmake/config-ix.cmake:221
 macro(get_test_cc_for_arch arch cc_out cflags_out)
-  if(ANDROID OR ${arch} MATCHES "arm|aarch64")
+  if(NOT APPLE AND (ANDROID OR ${arch} MATCHES "arm|aarch64"))
     # This is only true if we are cross-compiling.
----------------
delcypher wrote:
> The CMake documentation (https://cmake.org/cmake/help/v3.1/command/if.html) makes it look like (I've not verified this) the operator precedence is
> 
> ```
> NOT (APPLE AND (ANDROID OR ${arch} MATCHES "arm|aarch64"))
> ```
> 
> which is wrong because the second condition has been flipped compared to what existed prior to this patch.
> 
> Please explicitly use parentheses here to remove any ambiguity.
> 
> I'm guessing you wanted:
> 
> ```
> (NOT APPLE) AND (ANDROID OR ${arch} MATCHES "arm|aarch64"))
> ```
Sorry I meant

```
(NOT APPLE) AND (ANDROID OR ${arch} MATCHES "arm|aarch64")
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86379/new/

https://reviews.llvm.org/D86379