[PATCH] D86453: [AArch64] Support conversion between fp16 and fp128

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/lib/builtins/fp_extend.h:43
 #elif defined SRC_HALF
+#if defined COMPILER_RT_HAS_FLOAT16
+typedef _Float16 src_t;
----------------
`#ifdef` ? ditto below


================
Comment at: compiler-rt/test/builtins/Unit/trunctfhf2_test.c:15
+{
+    TYPE_FP16 x = __trunctfhf2(a);
+    int ret = compareResultH(x, expected);
----------------
Use 2-space indentation. Place `{` in the end. There is no need following the style of some violating files in this directory.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86453/new/

https://reviews.llvm.org/D86453