[PATCH] D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset.
Zarko Todorovski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 31 07:34:48 PDT 2020
ZarkoCA accepted this revision.
ZarkoCA added a comment.
This revision is now accepted and ready to land.
Looks good with minor nit.
================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1547
// Get the ABI.
bool isSVR4ABI = Subtarget.isSVR4ABI();
----------------
ZarkoCA wrote:
> I'm pretty sure this variable is no longer needed.
It looks like this causes a build failure with Werror on.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-framepointer-save-restore.ll:2
+; RUN: llc -verify-machineinstrs < %s -mcpu=pwr4 -mattr=-altivec \
+; RUN: -mtriple=powerpc-ibm-aix-xcoff | FileCheck %s -check-prefix=AIX32
+
----------------
nit: can the indentation be lined up?
================
Comment at: llvm/test/CodeGen/PowerPC/aix-framepointer-save-restore.ll:5
+; RUN: llc -verify-machineinstrs < %s -mcpu=pwr4 -mattr=-altivec \
+; RUN: -mtriple=powerpc64-ibm-aix-xcoff | FileCheck %s -check-prefixes=AIX64
+
----------------
same as above
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85850/new/
https://reviews.llvm.org/D85850
More information about the llvm-commits
mailing list