[PATCH] D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13996
 
   // (fneg (fmul c, x)) -> (fmul -c, x)
   if (N0.getOpcode() == ISD::FMUL &&
----------------
qiucf wrote:
> By the way, this can be removed since `getNegatedExpression` above already handles it?
Yes, that seems likely. This code also doesn't handle vectors, so if you can confirm/add tests for those patterns, this should go away.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86862/new/

https://reviews.llvm.org/D86862