[PATCH] D86867: [obj2yaml] Add support for dumping the .debug_str section.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:417
+      else if (RawSec->Name == ".debug_str")
+        dumpDebugStrings(*DWARFCtx.get(), DWARF);
 
----------------
I'd probably expect to see that `dumpDebugStrings` returns an error too, btw.
I can imagine cases when it should error out probably:
1) A string table that doesn't start with the null-byte.
2) A string table that doesn't end with the null byte.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86867/new/

https://reviews.llvm.org/D86867