[PATCH] D86744: [Attributes] Add a method to check if an Attribute has AttrKind None. Use instead of hasAttribute(Attribute::None)
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 19:19:57 PDT 2020
dblaikie added a comment.
my 2c would be to, if possible, remove the "none" state & possibly use Optional to express it in return values.
Short of that - removing the API to query for it and using explicit operator bool. Or maybe operator bool and "isValid" or similarly named function?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86744/new/
https://reviews.llvm.org/D86744
More information about the llvm-commits
mailing list