[PATCH] D86744: [Attributes] Add a method to check if an Attribute has AttrKind None. Use instead of hasAttribute(Attribute::None)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 16:18:00 PDT 2020


efriedma added a comment.

Maybe worth adding asserts to ensure we can't create an AttributeImpl for None?

Checking for isNone() is a little unintuitive; maybe something like `hasAttribute()` that checks for a non-None attribute would be better?  As it is, it's a double-negative in most places it's used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86744/new/

https://reviews.llvm.org/D86744



More information about the llvm-commits mailing list