[PATCH] D86843: [EarlyCSE] Equivalent SELECTs should hash equally
Bryan Chan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 30 11:07:26 PDT 2020
bryanpkc added a comment.
In D86843#2246545 <https://reviews.llvm.org/D86843#2246545>, @lebedev.ri wrote:
> 1. As a preparatory patch, we should adjust every test that uses EarlyCSE to also specify `-earlycse-debug-hash`, at least to those where it doesn't result in an assertion
Thanks for your suggestions, Roman. I have added the reproducer to the EarlyCSE tests, next to other similar test cases. Regarding your first suggestion, do you mean that we should enable `-earlycse-debug-hash` in all tests under `llvm/test/Transforms/EarlyCSE/`, or even all tests under `llvm/test/` that may implicitly use `EarlyCSE`? That seems like overkill.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86843/new/
https://reviews.llvm.org/D86843
More information about the llvm-commits
mailing list