[PATCH] D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}

[Shivam Gupta via Phabricator via llvm-commits]

xgupta added inline comments.
Herald added a subscriber: danielkiss.


================
Comment at: llvm/docs/CMake.rst:477
+    D:\git> git clone https://github.com/mjansson/rpmalloc
+    D:\llvm-project> cmake ... -DLLVM_INTEGRATED_CRT_ALLOC=D:\git\rpmalloc
+  This flag needs to be used along with the static CRT, ie. if building the
----------------
Sphinx documentation build produce a (warning) error with  >ninja docs/docs-llvm-html

FAILED: docs/CMakeFiles/docs-llvm-html 
cd /home/user/llvm-project-master/build/docs && /usr/bin/sphinx-build -b html -d /home/user/llvm-project-master/build/docs/_doctrees-llvm-html -q -t builder-html -W /home/user/llvm-project-master/llvm/docs /home/user/llvm-project-master/build/docs/html
/home/user/.local/lib/python3.8/site-packages/recommonmark/parser.py:75: UserWarning: Container node skipped: type=document
  warn("Container node skipped: type={0}".format(mdnode.t))

Warning, treated as error:
/home/user/llvm-project-master/llvm/docs/CMake.rst:476:Unexpected indentation.
ninja: build stopped: subcommand failed.

I think you should write these two lines as:-

  .. code-block:: console

    $ D:\git> git clone https://github.com/mjansson/rpmalloc
    $ D:\llvm-project> cmake ... -DLLVM_INTEGRATED_CRT_ALLOC=D:\git\rpmalloc



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786