[PATCH] D86845: [Attributor] Fix callsite check in AAUndefinedBehavior

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 29 20:46:16 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2050
+            isa<ConstantPointerNull>(*SimplifiedVal.getValue()))
+          KnownUBInsts.insert(&I);
       }
----------------
While you are here, move the `isa` into the conditional above. No need to create/query an AA if it's not a nullptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86845/new/

https://reviews.llvm.org/D86845



More information about the llvm-commits mailing list