[PATCH] D86842: [Attributor][NFC] Fix dependency type in AAUndefinedBehaviorImpl::updateImpl

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2034
+            *this, IRPosition::value(*ArgVal), /* TrackDependence */ true,
+            DepClassTy::OPTIONAL);
         Optional<Value *> SimplifiedVal =
----------------
If we only use known values you don't even need to track the dependence. here and above.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2077
               auto &NonNullAA = A.getAAFor<AANonNull>(
-                  *this, IRPosition::returned(*getAnchorScope()));
+                  *this, IRPosition::returned(*getAnchorScope()), /* TrackDependence */ true, DepClassTy::OPTIONAL);
               if (NonNullAA.isKnownNonNull())
----------------
clang-format the patch, also as above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86842/new/

https://reviews.llvm.org/D86842