[PATCH] D86839: [CMake] Remove -Wl,-allow-shlib-undefined which was added in rL221530
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 29 13:36:33 PDT 2020
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
Thanks!
I rather get approval from someone else on this as well though.
It can also be mentioned that Debian (and Ubuntu as a consequence) changed their default for adding automatically `--as-needed` a few years ago. I don't think it was the case at the time where we added `allow-shlib-undefined` to LLVM builds. Right now it means that the behaviors depends on the Linux distribution (non-Debian-based would not hit this bug), and if you're using clang or gcc as a driver to invoke the linker... (clang on Debian does not add --as-needed).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86839/new/
https://reviews.llvm.org/D86839
More information about the llvm-commits
mailing list