[PATCH] D59715: [HotColdSplit] Reflect full cost of parameters in split penalty

Fri Aug 28 22:26:22 PDT 2020

rjf accepted this revision.
rjf added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: danielkiss.

@vsk Hope these following data collected from compiling Firefox helps. The "Delta" values come from my previous patch: https://reviews.llvm.org/D84468. Based on the data, this patch performs very well at reducing the code size.
-Os:

| Delta | Size (including dynamic libraries) |  |
| ----- | ---------------------------------- |  |
| D59715 <https://reviews.llvm.org/D59715>     | 2.184796592 GB                             |
| 0     | 2.188262032 GB                             |
| 5     | 2.206931464 GB                             |
|

-O3:

| Delta | Size (including dynamic libraries) |  |
| ----- | ---------------------------------- |  |
| -2    | 2.270277648 GB                             |
| 0     | 2.247788640 GB                             |
| D59751 <https://reviews.llvm.org/D59751>     | 2.243288440 GB                             |
| 2     | 2.259242024 GB                             |
| 5     | 2.270277648 GB                             |

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59715/new/

https://reviews.llvm.org/D59715