[PATCH] D86812: [DebugInstrRef][1/3] Track PHI values through register allocation

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:459
+  public:
+    MachineBasicBlock *MBB; /// Block where this PHI was originally located.
+    Register Reg;           /// VReg where the control-flow-merge happens.
----------------
nit `///` comes before the field, `///<` after.


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:413
+  /// at different positions.
+  std::map<Register, std::vector<unsigned>> RegToPHIIdx;
+
----------------
do we need the sorted-ness of the map for determinism, or could we use a DenseMap?


================
Comment at: llvm/lib/CodeGen/PHIElimination.cpp:324
+    auto p = MachineFunction::DebugPHIRegallocPos(&MBB, IncomingReg, 0);
+    auto res = MF->DebugPHIPositions.insert(std::make_pair(ID, p));
+    assert(res.second);
----------------
insert({ID, p});


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86812/new/

https://reviews.llvm.org/D86812