[PATCH] D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.
Herald added a subscriber: danielkiss.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:679
+    bool hasPrivate;
+    while (itAllocate != allocateObjects_.end()) {
+      itPrivate = privateDataSharingAttributeObjects_.begin();
----------------
Can you use a range based for loop or std::for_each for this loop and the one below?


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:683
+      const Symbol &symbolAllocate{*itAllocate};
+      while (itPrivate != privateDataSharingAttributeObjects_.end()) {
+        const Symbol &symbolPrivate{*itPrivate};
----------------
Can you use std::find_if or range based for.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:686
+        if (symbolAllocate.name() == symbolPrivate.name()) {
+          hasPrivate = true;
+        }
----------------
Can break here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86051/new/

https://reviews.llvm.org/D86051