[PATCH] D86071: [MLIR][OpenMP] Add omp.do operation

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.
Herald added a subscriber: danielkiss.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:141
+             Variadic<AnyType>:$linear_vars,
+             Variadic<AnyType>:$linear_step_vars,
+             OptionalAttr<ScheduleKind>:$schedule_val,
----------------
Is this a single value or a list of values?


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:142-143
+             Variadic<AnyType>:$linear_step_vars,
+             OptionalAttr<ScheduleKind>:$schedule_val,
+             Optional<AnyType>:$schedule_chunk_var,
+             Optional<AnyType>:$collapse_var,
----------------
Is there a schedule modifier also?


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:144
+             Optional<AnyType>:$schedule_chunk_var,
+             Optional<AnyType>:$collapse_var,
+             OptionalAttr<UnitAttr>:$nowait,
----------------
This should be an attribute.
"The parameter of the collapse clause must be a constant positive integer expression."


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:146
+             OptionalAttr<UnitAttr>:$nowait,
+             Optional<AnyType>:$ordered_var,
+             OptionalAttr<OrderKind>:$order_val);
----------------
This should also be an attribute.
"The parameter of the ordered clause must be a constant positive integer expression if specified."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071