[PATCH] D86797: [early-ifcvt] Add OptRemarks
Jon Roelofs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 28 13:34:25 PDT 2020
jroelofs added a comment.
Herald added a subscriber: danielkiss.
In D86797#2244962 <https://reviews.llvm.org/D86797#2244962>, @thegameg wrote:
> This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.
Good call. As-is, this is probably more sensitive to changes in the passes that happen before `early-ifcvt` than it should be. Making it a MIR test should tighten that up a bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86797/new/
https://reviews.llvm.org/D86797
More information about the llvm-commits
mailing list