[PATCH] D86806: AMDGPU: Fix incorrectly deleting copies after spilling SGPR tuples

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 12:44:31 PDT 2020


arsenm created this revision.
arsenm added reviewers: rampitec, critson, Petar.Avramovic, kerbowa.
Herald added subscribers: danielkiss, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, qcolombet.
Herald added a project: LLVM.
arsenm requested review of this revision.
Herald added a subscriber: wdng.

The implicit def of the super register would appear to kill any live
uses of components before the spill, and would be deleted by
MachineCopyPropagation. We need to add implicit uses of the super
register, similarly to what copyPhysReg does. VGPR tuples appear to be
correctly handled already. I need to double check the SGPR->memory
path.


https://reviews.llvm.org/D86806

Files:
  llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
  llvm/test/CodeGen/AMDGPU/spill-reg-tuple-super-reg-use.mir
  llvm/test/CodeGen/AMDGPU/spill192.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86806.288678.patch
Type: text/x-patch
Size: 10277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200828/94a5da68/attachment.bin>


More information about the llvm-commits mailing list