[PATCH] D84220: [IPSCCP] Fix a bug that the "returned" attribute is not cleared when function is optimized to return undef
Congzhe Cao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 28 11:57:55 PDT 2020
congzhe added a comment.
Thanks for the comments.
Now removed the include of AbstractCallBase. Also fixed the lack of periods in comments. Clang-format-ed the code.
Added a test case for the `blockaddr` case.
================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:37
#include "llvm/Analysis/ValueLatticeUtils.h"
+#include "llvm/IR/AbstractCallSite.h"
#include "llvm/IR/BasicBlock.h"
----------------
fhahn wrote:
> congzhe wrote:
> > fhahn wrote:
> > > Is this needed?
> > This header file is included since we need the CallBase class when we remove the returned attribute in call sites.
> CallBase is defined here `https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/IR/InstrTypes.h#L1100`, which is already included?
>
>
Thanks, now removed the include of AbstractCallBase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84220/new/
https://reviews.llvm.org/D84220
More information about the llvm-commits
mailing list