[PATCH] D86799: [WIP] Experimental Debug Location Verifier.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Very cool. Does this fire at all in an -O0 stage2 build?



================
Comment at: llvm/lib/IR/Verifier.cpp:4213
+  AssertDI(isa<DILocation>(N), "invalid !dbg metadata attachment", &I, N);
+  // If an instruction has a source location, then all occurrences of
+  // each operand's source location must dominate this instruction or
----------------
s/all occurrences/the first occurrence in any block/? Or do we mean to check the 'all' condition?


================
Comment at: llvm/lib/IR/Verifier.cpp:4216
+  // be in the same BB as the instruction.
+  Instruction *Op = cast<Instruction>(I.getOperand(i));
+
----------------
Is I.getOperand(i) guaranteed to be an Instruction? What about constants?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86799/new/

https://reviews.llvm.org/D86799