[PATCH] D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab

Fri Aug 28 11:40:29 PDT 2020

dmajor added a comment.

Hi, we're seeing an assertion failure in one of the Firefox LTO bots:

  char llvm::StringRef::operator[](size_t) const: Assertion `Index < Length && "Invalid index!"' failed.

I'm still working on finishing the bisection but I have a hunch that it may be this change. Unfortunately I can't seem to get a backtrace out of this particular bot.

As a guess, could it be the `operator[]` in `getGlobalIdentifier` at https://github.com/llvm/llvm-project/blob/4cb016cd2d8467c572b2e5c5d34f376ee79e4ac1/llvm/lib/IR/Globals.cpp#L140 ? It looks like there was previously a check for `Name.size() > 0` that isn't checked anymore.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84803/new/

https://reviews.llvm.org/D84803