[PATCH] D86762: [ELF] Add documentation for --warn-backrefs: a layering check tool

Fri Aug 28 11:30:27 PDT 2020

MaskRay added a comment.

In D86762#2244878 <https://reviews.llvm.org/D86762#2244878>, @manojgupta wrote:

>> `--warn-backrefs-exclude='*'` disables all warnings. We may need `--no-warn-backrefs` if it is more like the option users want to use. If you are happy to try out, I'd happy to know whether ChromeOS packages have no warnings if `--warn-backrefs` is added (`--fatal-warnings` upgrade warnings to errors).
>
> To me,  `--no-warn-backrefs` is more convenient and obvious. Use of "*" in a compiler or linker option can be problematic because of potential expansion of "*" by shell/tools especially when the option goes through multiple layers of tools.
> And yes, we can definitely test on Chrome OS if making it default with fatal errors causes a problem for us.

dblaikie asked "Would you like to conduct the conversation here, or on the review thread?"

We can move the "can we make --warn-backrefs suggestions" discussions to https://lists.llvm.org/pipermail/llvm-dev/2020-August/144634.html

This review can be focused on the documentation of the diagnostic (I hope that the option is important enough that it justifies its own page).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86762/new/

https://reviews.llvm.org/D86762