[PATCH] D86178: [ObjCARCOpt] Port objc-arc to NPM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D86178#2243750 <https://reviews.llvm.org/D86178#2243750>, @ychen wrote:

> It looks like belong to `addFunctionSimplificationPasses`. How about keeping it Function pass using initialization once?

The reason I made this a module pass instead of a function pass is because it adds function declarations when there is a call to `EP.get()`. I'm not sure if you're allowed to add function declarations in a function pass. If we were to try to parallelize function passes, that would be bad.
We could split the creation of all the functions in ARCRuntimeEntryPoints into a separate module pass, but that would have to be run right before this function pass and wouldn't help with adding it to a FunctionPassManager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86178/new/

https://reviews.llvm.org/D86178