[PATCH] D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

My vote hasn't changed, I mean I already accepted the tweaked Option1 so you could have been done and dusted by now :)  I just don't see what's gained from Option3's refactoring.  It does the same as Option1 but in a less type safe/flexible/c++ way.  Furthermore, the new interface is needlessly different to the other functions that handle SVE immediate values when the vector element type plays a role.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85225/new/

https://reviews.llvm.org/D85225