[PATCH] D86687: [DAGCombiner] Enhance (zext(setcc))

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 09:01:02 PDT 2020


spatel added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/hoist-and-by-const-from-lshr-in-eqcmp-zero.ll:314
 ;------------------------------------------------------------------------------;
 ; A few negative tests
 ;------------------------------------------------------------------------------;
----------------
lkail wrote:
> xbolva00 wrote:
> > Adjust comment?
> Hmmm, interesting, the function name also indicates it's negative.
Yes, please update comment.
https://alive2.llvm.org/ce/z/AEzNaw
Side note: in IR, -instcombine doesn't get this, but -sccp does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86687/new/

https://reviews.llvm.org/D86687



More information about the llvm-commits mailing list