[PATCH] D85368: [llvm][CodeGen] Machine Function Splitter

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:123
+      continue;
+    if (isColdBlock(MBB, MBFI, PSI)) {
+      MBB.setSectionID(MBBSectionID::ColdSectionID);
----------------
nit: redundant braces,


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:216
+/// Enable the machine function splitter pass.
+/// FIXME: Remove this once clang option for this feature has been added.
+static cl::opt<bool> EnableMachineFunctionSplitter(
----------------
Remove this FIXME. most passes continue to have cl::opt anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85368/new/

https://reviews.llvm.org/D85368