[PATCH] D86706: [LLD][PowerPC] Add pc-rel based long branch thunks

[Victor Huang via Phabricator via llvm-commits]

NeHuang marked an inline comment as done.
NeHuang added inline comments.


================
Comment at: lld/ELF/Thunks.cpp:968
+  if (!isInt<34>(offset))
+    fatal("offset overflow 34 bits, use large code model with mcmodel=large");
+  uint64_t paddi = PADDI_R12_NO_DISP | (((offset >> 16) & 0x3ffff) << 32) |
----------------
sfertile wrote:
> Real minor nit: `mcmodel=large` is a helpful hint, but I think its only relevant if you are using a C/C++ compiler and maybe fortran. It might be confusing if you are linking objects that came from a different source language.
Thanks, message updated. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86706/new/

https://reviews.llvm.org/D86706