[PATCH] D86772: [llvm-readobj] - Remove Error.cpp,.h and drop dependencies in the code.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 04:09:39 PDT 2020


sbc100 added inline comments.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:640
   else
-    reportError(errorCodeToError(readobj_error::unrecognized_file_format),
-                File);
+    // Not tested, because all possible file types are handled.
+    reportError(
----------------
Should we assert or llvm_unreachable here then?  Since it should be impossible to get here because the above "case" statement should handle all valid file types?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86772/new/

https://reviews.llvm.org/D86772



More information about the llvm-commits mailing list