[PATCH] D86725: [MemLoc] Support memcmp in MemoryLocation::getForArgument.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 04:08:27 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/MemoryLocation.cpp:225
+      break;
+    case LibFunc_memcmp:
+      assert((ArgIdx == 0 || ArgIdx == 1) &&
----------------
xbolva00 wrote:
> bcmp too?
> 
> LLVM transforms memcmp(...) == 0 to bcmp == 0.
Yes, there are a lot of cases missing that we could support here. I won't have time to add all those in the near future unfortunately, any help/patches would be very welcome :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86725/new/

https://reviews.llvm.org/D86725



More information about the llvm-commits mailing list