[PATCH] D86065: [SVE] Make ElementCount members private

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 03:06:27 PDT 2020


paulwalker-arm added a comment.

Can't say I agree since people are already writing the ugly code, because the result typically demands different handling or they're asserting the divide doesn't truncate in the first place.  That said I'm happy for there to be no assert as long as operator% is implemented so users can calculate the remainder in the expected way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86065/new/

https://reviews.llvm.org/D86065



More information about the llvm-commits mailing list