[PATCH] D86769: [UpdateTestChecks] include { in function signature check line

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 01:25:56 PDT 2020


sstefan1 created this revision.
sstefan1 added reviewers: jdoerfert, MaskRay, lebedev.ri, arichardson.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
sstefan1 requested review of this revision.

After D85099 <https://reviews.llvm.org/D85099>, if we have attribute group in the function signature that hasn't
been seen before, and later a callsite with the same attribute group, filecheck will evaluate
the first attribute group to for example '#0 {'. We now include { in the args_and_sig group to avoid this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86769

Files:
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/argument_name_reuse.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll.funcsig.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/check_attrs.ll.funcattrs.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/check_attrs.ll.plain.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.initially_disabled.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.expected
  llvm/utils/UpdateTestChecks/common.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86769.288547.patch
Type: text/x-patch
Size: 8997 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200828/d4decdd0/attachment.bin>


More information about the llvm-commits mailing list