[PATCH] D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14059
+      // unconditionally take the branch, remove all other successors of CurBB
+      auto SuccMBB = CurMBB->succ_begin();
+      while (SuccMBB != CurMBB->succ_end()) {
----------------
I'm not sure if we can really do this from SelectionDAG. Is there anywhere else that does this in tree?


================
Comment at: llvm/test/CodeGen/X86/test-shrink.ll:574
   ret void
 no:
   ret void
----------------
Can we pre-commit the IR changes here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86578/new/

https://reviews.llvm.org/D86578