[PATCH] D85561: [BasicBlockUtils] Factor MergeBlockIntoPredecessor args into a struct, NFC

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

lgtm with some nits.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:2230
+    MergeOpts.MemDep = MD;
+    bool removedBlock = MergeBlockIntoPredecessor(BB, MergeOpts);
     if (removedBlock)
----------------
s/removedBlock/RemovedBlock (see clang-tidy or llvm doc)


================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:2230
+    MergeOpts.MemDep = MD;
+    bool removedBlock = MergeBlockIntoPredecessor(BB, MergeOpts);
     if (removedBlock)
----------------
asbirlea wrote:
> s/removedBlock/RemovedBlock (see clang-tidy or llvm doc)
Perhaps directly passing: {&DTU, LI, nullptr, MD}?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85561/new/

https://reviews.llvm.org/D85561