[PATCH] D86740: [flang][NFC] Change how error symbols are recorded

[Tim Keith via Phabricator via llvm-commits]

tskeith created this revision.
tskeith added reviewers: klausler, PeteSteinfeld, sscalpone.
tskeith added a project: Flang.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
tskeith requested review of this revision.

When an error is associated with a symbol, it was marked with a flag
from Symbol::Flag. The problem with that is that you need a mutable
symbol to do that. Instead, store the set of error symbols in the
SemanticsContext. This allows for some const_casts to be eliminated.

Also, improve the internal error that occurs if SetError is called
but no fatal error has been reported.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86740

Files:
  flang/include/flang/Semantics/semantics.h
  flang/include/flang/Semantics/symbol.h
  flang/include/flang/Semantics/type.h
  flang/lib/Semantics/expression.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/semantics.cpp
  flang/lib/Semantics/tools.cpp
  flang/lib/Semantics/type.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86740.288463.patch
Type: text/x-patch
Size: 8307 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200827/e9930538/attachment.bin>