[PATCH] D86718: [llvm-readobj] - Simplify the code that creates dumpers. NFCI.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 14:18:38 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Because currently we call many `print*` after the dumper is created. The many `print*` may fail due to the same reason. If we one day we want to change, we can call a verification method before `print*`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86718/new/

https://reviews.llvm.org/D86718



More information about the llvm-commits mailing list