[PATCH] D86528: [4/5] [MC] [Win64EH] Fill in FuncletOrFuncEnd if missing

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/MC/MCStreamer.cpp:696
+  if (!CurFrame->FuncletOrFuncEnd)
+    CurFrame->FuncletOrFuncEnd = CurFrame->End;
 }
----------------
Instead of setting FuncletOrFuncEnd here, should we be calling EmitWinCFIFuncletOrFuncEnd somewhere?


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:531
+    // This can happen if unwind info is forced to be generated (with a
+    // .seh_handlerdata directive) directly after the start of the function.
     RawFuncLength = 0;
----------------
With the other changes in this patch, is it still possible for FuncletOrFuncEnd to be null?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86528/new/

https://reviews.llvm.org/D86528