[PATCH] D86734: [Attributor] Do not add AA to dependency graph after the update stage

Shinji Okumura via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 13:18:13 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG58d257b2904b: [Attributor] Do not add AA to dependency graph after the update stage (authored by okura).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86734/new/

https://reviews.llvm.org/D86734

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h


Index: llvm/include/llvm/Transforms/IPO/Attributor.h
===================================================================
--- llvm/include/llvm/Transforms/IPO/Attributor.h
+++ llvm/include/llvm/Transforms/IPO/Attributor.h
@@ -1104,8 +1104,10 @@
     assert(!AAPtr && "Attribute already in map!");
     AAPtr = &AA;
 
-    DG.SyntheticRoot.Deps.push_back(
-        AADepGraphNode::DepTy(&AA, unsigned(DepClassTy::REQUIRED)));
+    // Register AA with the synthetic root only before the manifest stage.
+    if (Phase == AttributorPhase::SEEDING || Phase == AttributorPhase::UPDATE)
+      DG.SyntheticRoot.Deps.push_back(
+          AADepGraphNode::DepTy(&AA, unsigned(DepClassTy::REQUIRED)));
 
     return AA;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86734.288440.patch
Type: text/x-patch
Size: 715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200827/dede6455/attachment.bin>


More information about the llvm-commits mailing list