[PATCH] D86635: [Attributor] Guarantee getAAFor not to update AA in the manifestation stage

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, without print, if you want the print we can talk about it.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:983
+          LLVM_DEBUG(dbgs() << "[Attributor] An update is forced outside of "
+                               "the update stage. Ignore this enforcement.\n");
+        else
----------------
okura wrote:
> Some AA uses the same helper function that contains `getAndUpdateAAFor` in both `updateImpl` and `manifest`. Therefore, we should ignore the enforcement in this case rather than abort.
> Though I want to use a debug printer here for this reason, `#define DEBUG_TYPE "attributor"` is not defined in `Attributor.h`.
> If there is no reason to put the implementation `Attributor.h`, I want to move the implementation into `Attributor.cpp`.
> I want to move the implementation into Attributor.cpp.

That doesn't work because we need to specialize the template (I think).

I'd go without a print for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86635/new/

https://reviews.llvm.org/D86635