[PATCH] D85404: [lld-macho] Handle TAPI and regular re-exports uniformly

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

Hi! I believe our mac builders are failing after this change with

  FAIL: lld :: MachO/invalid/stub-link.s (2106 of 2478)
  ******************** TEST 'lld :: MachO/invalid/stub-link.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   mkdir -p /b/s/w/ir/k/staging/llvm_build/tools/lld/test/MachO/invalid/Output/stub-link.s.tmp
  : 'RUN: at line 5';   /b/s/w/ir/k/staging/llvm_build/bin/llvm-mc -filetype obj -triple x86_64-apple-ios /b/s/w/ir/k/llvm-project/lld/test/MachO/invalid/stub-link.s -o /b/s/w/ir/k/staging/llvm_build/tools/lld/test/MachO/invalid/Output/stub-link.s.tmp/test.o
  : 'RUN: at line 6';   not lld -flavor darwinnew -o /b/s/w/ir/k/staging/llvm_build/tools/lld/test/MachO/invalid/Output/stub-link.s.tmp/test -Z -L/b/s/w/ir/k/llvm-project/lld/test/MachO/invalid/../Inputs/iPhoneSimulator.sdk/usr/lib -lSystem /b/s/w/ir/k/staging/llvm_build/tools/lld/test/MachO/invalid/Output/stub-link.s.tmp/test.o 2>&1 | /b/s/w/ir/k/staging/llvm_build/bin/FileCheck /b/s/w/ir/k/llvm-project/lld/test/MachO/invalid/stub-link.s
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/lld/test/MachO/invalid/stub-link.s:8:14: error: CHECK-DAG: expected string not found in input
  # CHECK-DAG: error: undefined symbol __cache_handle_memory_pressure_event
               ^
  <stdin>:1:1: note: scanning from here
  lld: error: undefined symbol _from_non_reexported_tapi_dylib, referenced from test.o
  ^
  <stdin>:1:6: note: possible intended match here
  lld: error: undefined symbol _from_non_reexported_tapi_dylib, referenced from test.o
       ^
  
  Input file: <stdin>
  Check file: /b/s/w/ir/k/llvm-project/lld/test/MachO/invalid/stub-link.s
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
           1: lld: error: undefined symbol _from_non_reexported_tapi_dylib, referenced from test.o
  dag:8'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
  dag:8'1          ?                                                                               possible intended match
  >>>>>>
  
  --

I see that you sent out a fix for the objc.s test. Would you mind taking a look at this one? Thanks.

Builder: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-mac-x64/b8870848238102897488?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85404/new/

https://reviews.llvm.org/D85404