[PATCH] D86584: [flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop
Peter Klausler via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 09:24:52 PDT 2020
klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.
================
Comment at: flang/lib/Parser/openacc-parsers.cpp:144
+ maybe(("NUM:"_tok >> scalarIntExpr || scalarIntExpr)),
+ maybe(","_tok / "STATIC:"_tok >> Parser<AccSizeExpr>{})))
----------------
`","_tok / "STATIC:"_tok >>` can be written better as just `", STATIC" >>`.
The production does not match the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86584/new/
https://reviews.llvm.org/D86584
More information about the llvm-commits
mailing list