[PATCH] D72148: [DSE] Support traversing MemoryPhis.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 09:04:59 PDT 2020
fhahn added a comment.
In D72148#2242301 <https://reviews.llvm.org/D72148#2242301>, @ebrevnov wrote:
>> I won't have time to look into this in the near future unfortunately, as I am mainly focused on getting things in good shape to enable DSE & MemorySSA by default. It might be good to file a bug report so this opportunity does not drop off our radar. If anyone is interested in giving implementing it a try, even better :)
>
> Florian, thank you for quick feedback. I prototyped phi translation approach and it does work on the posted test case. Unfortunately, it fails on a bit more complicated case which I will take a look tomorrow. If I have something working reasonably well in the end I will share it.
That's great! There are some changes to how we find MemoryDefs that may be killed by a killing def, rGe717fdb0f155 <https://reviews.llvm.org/rGe717fdb0f155deaa03eaae891bd34743e6ffcb64> and D86487 <https://reviews.llvm.org/D86487>. This might actually make things a bit easier, as we now fully control the traversal of the defining accesses.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72148/new/
https://reviews.llvm.org/D72148
More information about the llvm-commits
mailing list