[PATCH] D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call.

[Hamilton Tobon Mosquera via Phabricator via llvm-commits]

hamax97 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:940
+        return false;
+
+      // TODO: Check if MT can be moved upwards.
----------------
jdoerfert wrote:
> We should dump MT or do something to test this.
> 
> Also, do we store MT somewhere? Otherwise we might be able to just use a object that cannot be copied.
Sure, I'll use `LLVM_DEBUG` to print `MT.Issue` and I'll create another regression test that checks for that debug information.

Sure, I'll do it. `MT` is intended to be used for the next step in the algorithm, that is, determining where `MT.Issue` can be moved. But not for long term storage.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:976
+    Value *SizesArg =
+        RuntimeCall.getArgOperand(OffloadArray::SizesArgNum);
 
----------------
jdoerfert wrote:
> Commit this part as NFC before this patch.
Before I can commit this we need to commit https://reviews.llvm.org/D86300.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86474/new/

https://reviews.llvm.org/D86474