[PATCH] D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 08:10:20 PDT 2020
aganea added inline comments.
================
Comment at: llvm/lib/Support/CMakeLists.txt:69
+
+ string(REGEX REPLACE "/$" "" LLVM_INTEGRATED_CRT_ALLOC "${LLVM_INTEGRATED_CRT_ALLOC}")
+
----------------
hans wrote:
> Should this also handle trailing backslash?
Done & tested. Altough with cmake I've learned to always use forward slashes, even on Windows, otherwise it always fails in some way or another :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71786/new/
https://reviews.llvm.org/D71786
More information about the llvm-commits
mailing list