[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:205
+    // The codegen IR pipeline are mostly function passes with the exceptions of
+    // a few loop and module passes. `AddingFunctionPasses` make sures that
+    // we could only add module passes at the beginning of the pipeline. Once
----------------
Typo 'sures'


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:211
+    // implementation to accommodate that.
+    Optional<bool> AddingFunctionPasses;
+  };
----------------
I don't understand why this is optional


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:225
+          "Machine function pass must define a static member variable `Key`.");
+      for (auto &C : BeforeCallbacks)
+        if (!C(&PassT::Key))
----------------
Braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608